Skip to content

feat(dart_frog_cli): support for Dart workspaces #1825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

feat(dart_frog_cli): support for Dart workspaces #1825

wants to merge 22 commits into from

Conversation

felangel
Copy link
Contributor

@felangel felangel commented Aug 8, 2025 •
edited
Loading

Status

READY

Description

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel self-assigned this Aug 8, 2025
@felangel felangel changed the title feat(dart_frog_cli): support for Dart workspaces fix(dart_frog_cli): support for Dart workspaces Aug 8, 2025
@felangel felangel changed the title fix(dart_frog_cli): support for Dart workspaces feat(dart_frog_cli): support for Dart workspaces Aug 8, 2025
@felangel felangel added feature A new feature or request product: cli Issues related to the Dart Frog CLI labels Aug 8, 2025
@felangel
Copy link
Contributor Author

felangel commented Aug 8, 2025

Need to write a bunch of tests. Planning to do that tomorrow afternoon and hopefully land/release this by Monday.

@alestiago alestiago requested a review from marcossevilla August 8, 2025 07:33
@felangel felangel marked this pull request as ready for review August 12, 2025 02:58
@felangel felangel requested a review from alestiago August 12, 2025 03:06
erickzanardo
erickzanardo previously approved these changes Aug 12, 2025
View reviewed changes
@felangel
Copy link
Contributor Author

Going to hold off merging because I found an edge case that breaks with this approach

renancaraujo
renancaraujo previously approved these changes Aug 20, 2025
View reviewed changes
@felangel
Copy link
Contributor Author

felangel commented Aug 20, 2025 •
edited
Loading

This breaks the external package copy logic because it doesn't take into account transitive dependencies. I'm not sure that we should even be copying external packages because we can just have dart frog build accept a workspace root instead (and we wouldn't need to do any copying) but that would be a breaking change.

@felangel felangel mentioned this pull request Aug 21, 2025
Merged
7 tasks
@felangel
Copy link
Contributor Author

Planning to rework this in the coming days and hope to ship this next week. Apologies for the delay!

@felangel felangel dismissed stale reviews from renancaraujo and erickzanardo via 30df8ed August 27, 2025 04:25
@felangel
Copy link
Contributor Author

felangel commented Aug 27, 2025 •
edited
Loading

I think this should be ready for re-review finally 🥳
Going to do some more smoke testing tomorrow and hopefully we can land this and release shortly 🤞

EDIT:
Nevermind, still need to fix a few more things. Hopefully should be ready tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcossevilla marcossevilla Awaiting requested review from marcossevilla marcossevilla is a code owner

@wolfenrain wolfenrain Awaiting requested review from wolfenrain wolfenrain is a code owner

@alestiago alestiago Awaiting requested review from alestiago alestiago is a code owner

@erickzanardo erickzanardo Awaiting requested review from erickzanardo erickzanardo is a code owner

@renancaraujo renancaraujo Awaiting requested review from renancaraujo renancaraujo is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@felangel felangel

Labels
feature A new feature or request product: cli Issues related to the Dart Frog CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: dart_frog build in a pub workspace (dart ^3.5)
4 participants
@felangel @erickzanardo @renancaraujo @alestiago